Message |
|
In the file templates/default/user_profile.htm, replace registrationDay with registrationDate - that will use the format you selected. Note that in the topic view, the format will still use the short version "Jul 6, 2011", because there space is at a premium. Attached is a new JForum jar file that has the fix for Oracle. If you replace the one you have with this one, it should work regardless of the cache setting. Let me know how it works out for you.
|
 |
|
jdev1 wrote:I found reason of my problem it's "topic.cache.enabled" in SystemGlobal.properties. When it's "true" it uses selectAllByForum with MAX.integer as argument that's why it was 2147483647 as value.
That addresses the symptom, not the problem. If I provide you with a version that includes the fix I posted above, would you be willing to test that?
|
 |
|
AN NPE sounds like some value is missing, so make sure all fields required for sending emails (basically, all fields above "Send a test email") have correct values in them.
|
 |
|
jdev1 wrote:I looked at the history of sql queries in Oracle and saw that when executing the query Topic Model.selectAllByForumByLimit variables for the block "WHERE LINENUM >= ? AND LINENUM < ?" 0 and 2147483647 are passed.
The value 2147483647 interesting, that sounds suspiciously like "-1", as used in GenericTopicDAO.selectAllByForum, and should cause TopicModel.selectAllByForum to be used rather than TopicModel.selectAllByForumByLimit. That is an optimization which apparently was never fixed for the Oracle code. I think this is what should be in OracleTopicDAO:
@Override public List<Topic> selectAllByForumByLimit (final int forumId, final int startFrom, final int count)
{
if (count < 0)
return super.selectAllByForumByLimit(forumId, startFrom, count);
else
return super.selectAllByForumByLimit(forumId, startFrom, startFrom + count);
}
|
 |
|
No, it should be TopicModel.selectAllByForumByLimit in oracle.sql I don't recall when selectAllByForum is executed, and when selectAllByForumByLimit, but only the latter one is overridden for Oracle.
|
 |
|
|
 |
|
|
 |
|
Actually, the software does scale the image down if it is too large, so no change is needed. Not sure what's going on with this server, but it seems JForum does the right thing.
|
 |
|
Thanks for the patch, I've just committed it (minus a bug that caused an exception if the number of results on the last page wasn't the same as the number of topics per page).
|
 |
|
The base problem seems to be that the first page shows all 35 results, when it should only be showing 15. So yes, that looks like a bug. I'll put it on my list.
|
 |
|
Thanks for the heads-up. Not sure what is going on with the server, we'll look into it. It's unlikely to be missing libraries, that's just one of the things that can go wrong. But I agree that there's little point in requiring an image of a particular size - it should just be scaled down to a reasonable size. We'll make that change for the next release.
|
 |
|
We've just released JForum 2.8.1, which contains a number of small fixes and improvements that we've made over the last 9 months.
Various font and background colors can be configured at runtime from the Configurations page. So if you ever disliked some particular color JForum used, chances are you can now change it without even the need of a restart.
More control over image attachments from the Configurations page
Optimize Recent Topics and Hot Topics for large installations. Large meaning at least 100.000 posts before it will make a difference.
Fixed an issue where the last visited time on the forum home page was not actually reflecting that, but the time of the last session start
Switch optional Google Analytics integration from analytics.js to gtag.js
Fixed a CSRF vulnerability
As always, many dependencies haven been updated to the latest versions. A full list of new features is at https://sourceforge.net/p/jforum2/wiki2/NewFeatures281/, upgrade instructions are at https://sourceforge.net/p/jforum2/wiki2/UpgradingFrom280to281/ and you can download it from https://sourceforge.net/projects/jforum2/files/. The documentation is at https://sourceforge.net/p/jforum2/wiki2/Documentation/ All feedback is welcome.
|
 |
|
I think it's fixed. You can grab the source code from SVN to build it now, or wait for the upcoming 2.8.1 release - which should happen within the next few weeks.
|
 |
|
I had taken a first stab at this (which you can find in SVN), but it doesn't yet do what I want it to do. So, more work is needed, which I may get around to in the next few weeks.
|
 |
|
I see what you mean. This will be addressed in the next release.
|
 |
|