Latest topics for the forum "Developer Forum"

Re:search problem

jdev1 — GMT

[quote]This kind of issue is hard to track down without having access to the forum in question. Can you reproduce it on this site?[/quote]
No, there is another problem, take a look at images

[quote]You mean clicking the pagination buttons?[/quote]
Yes

[quote]What specifically did you test, and what, exactly, was the result?[/quote]
By changing search options. Problem shows only when i type 2 or more keywords

Email Integration Tests

udittmer — GMT

If the test fail, there should be exception stack messages in the output - post those here in full. Without those, it's hard to tell what's going wrong.

Re:Search Pagination is broken?

Komal Gupta — GMT

[code]
Index: src/main/java/net/jforum/search/LuceneContentCollector.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- src/main/java/net/jforum/search/LuceneContentCollector.java (revision 974)
+++ src/main/java/net/jforum/search/LuceneContentCollector.java (date 1658338387000)
@@ -64,33 +64,38 @@
import org.apache.lucene.search.highlight.QueryScorer;
import org.apache.lucene.search.highlight.SimpleHTMLFormatter;

+import net.jforum.util.preferences.ConfigKeys;
+import net.jforum.util.preferences.SystemGlobals;
+
import org.apache.log4j.Logger;

/**
* @author Rafael Steil
*/
-public class LuceneContentCollector
-{
+public class LuceneContentCollector {
private static final Logger LOGGER = Logger.getLogger(LuceneContentCollector.class);

private LuceneSettings settings;

- public LuceneContentCollector (LuceneSettings settings)
- {
+ public LuceneContentCollector(LuceneSettings settings) {
this.settings = settings;
}

- public List collect (SearchArgs args, ScoreDoc[] results, Query query) {
+ public List collect(SearchArgs args, ScoreDoc[] results, Query query, int totalHits) {
try {
- int finalResultSize = Math.min(args.fetchCount(), results.length - args.startFrom());
+ int finalResultSize = Math.min(args.fetchCount(), totalHits - args.startFrom());
+// LOGGER.debug(String.format("collect: results=%d, args.fetchCount=%d, args.startFrom=%d, finalResultSize=%d", results.length, args.fetchCount(), args.startFrom(), finalResultSize));
int[] postIds = new int[finalResultSize];
- //LOGGER.debug(String.format("collect: results=%d, args.fetchCount=%d, args.startFrom=%d",
- // results.length, args.fetchCount(), args.startFrom()));

IndexSearcher searcher = new IndexSearcher(DirectoryReader.open(this.settings.directory()));
- for (int docIndex = args.startFrom(), i = 0;
- i < finalResultSize;
- docIndex++, i++) {
+
+ int docIndex = args.startFrom();
+ while (docIndex > SystemGlobals.getIntValue(ConfigKeys.SEARCH_RESULT_LIMIT)) {
+ docIndex -= SystemGlobals.getIntValue(ConfigKeys.SEARCH_RESULT_LIMIT);
+ }
+ LOGGER.debug(String.format("docIndex=%d", docIndex));
+
+ for (int i = 0; i < finalResultSize; docIndex++, i++) {
ScoreDoc hit = results[docIndex];
Document doc = searcher.doc(hit.doc);
postIds[i] = Integer.parseInt(doc.get(SearchFields.Keyword.POST_ID));
Index: src/main/java/net/jforum/search/LuceneSearch.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- src/main/java/net/jforum/search/LuceneSearch.java (revision 974)
+++ src/main/java/net/jforum/search/LuceneSearch.java (date 1658338329000)
@@ -158,7 +158,7 @@
ScoreDoc[] docs = tfd.scoreDocs;
TotalHits th = tfd.totalHits;
if (th.value > 0) {
- result = new SearchResult<>(resultCollector.collect(args, docs, query), (int) th.value);
+ result = new SearchResult<>(resultCollector.collect(args, docs, query, (int) th.value), (int) th.value);
} else {
result = new SearchResult<>(new ArrayList<>(), 0);
}

[/code]

Bug in Profile editing

udittmer — GMT

Actually, the software does scale the image down if it is too large, so no change is needed. Not sure what's going on with this server, but it seems JForum does the right thing.

Re:Session and Last Visit Time are conflicting

Komal Gupta — GMT

Thanks for the update!

The "Group By Forum" functionality is broken.

udittmer — GMT

This has been fixed in 2.8.0, BTW.

Deleted file "clipboard.swf" still being referenced

udittmer — GMT

Thanks for the heads-up. I've removed that and some other remnants of the old SyntaxHighlighter.

Code ever moved to Git?

udittmer — GMT

Although we are getting closer to moving to Git, that has not happened yet, and will probably not happen real soon. For the time being, the best way to contribute would be to open a ticket at https://sourceforge.net/p/jforum2/tickets/ and attach a diff against the current Subversion HEAD.

Running the JForum2 unit tests

udittmer — GMT

This post is more of a note to myself than a question, but if anyone has suggestions on how to make the process smoother, I'm all ears.

1) Temporarily remove the net.jforum.summary.SummaryTest.java file. The test never finishes, although that may be more of a Quartz issue than an issue with the test itself.

2) Add the jforum-custom.conf file from your installation to src/main/config - it contains the DB configurations needed to run the tests.

3) Temporarily remove src/main/config/database/postgresql/postgresql.properties (or the corresponding file for whatever DB you're using for the tests). The file is loaded after the jforum-custom.properties, and thus overrides it.

An alternative to steps 2 and 3 would be to edit src/main/config/database/postgresql/postgresql.properties so it contains the values appropriate to your DB.

4) Then perform a [i]clean[/i] build when running the tests.

5) Afterwards, undo the above changes before creating the actual build.

pom.xml doesn't work

udittmer — GMT

Thanks for the heads-up. I'm not sure why those repositories (or jfrog) are listed there. I'll look into whether they can just be deleted, or if any compensatory setup is required.

Re:Running JForum Clustered

xchene — GMT

Hi,
I have it clustered (2 nodes), common DB and File System.
Working fine, except that Category and Forum are loaded at application start, and not refreshed automatically on the node that you are not using when administering the forums.
Meaning, you see two different state of the forum index, depending on the cluster node you are connected.
This forces me to restart the application, which is not nice in a production environment.

So, it would be nice to have the Category and Forum list regularly refreshed (or never cached), or an option to refresh it on each node, or a cluster feature that will allow to inform the other nodes to refresh the Category and Forum list.
It could be that other features are concerned, not discovered yet, but I'mm quite new in jForum.

Can somebody include that in a next release ?

Re:JForum 3.x Ideas

XAOS-Eric — GMT

[quote=udittmer]I consider swooping in and trying to get hold of the domain that has been associated with this project for more than a decade an unfriendly move. That's not the way to build momentum for your project.[/quote]
I have spoken with the owner of the domain about buying it previously before finding out about this fork and he wanted a lot for it, however, now that I know this fork exists I understand how that could be considered unfriendly and I have canceled the backorder. if I were to buy the domain or somehow get it, I would transfer it to one of you. That being said, if I were to get jforum.io, I would get it at Namecheap and set it up so you two could manage it.

[quote=udittmer]git would be nice, but so far it hasn't been important enough for anyone on the team to tackle. SF has an issue tracker as well, by the way (which is being used). The JForum 2 and 3 stuff on Github is obsolete; it's there merely for historical interest.[/quote]
I also took the time last night to move the source code to GitLab (https://gitlab.com/jforum/jforum), if you have an account on GitLab, I can add you to the organization. Now that it is there, if you are part of the git organization on GitHub (https://github.com/jforum), it will be easier for you to transfer the code with all the commit history if that is something you want to do.

Re:Can the Software Look and Feel be customised?

satinder_2000@outlook.com — GMT

Many Thanks

Trying to locate code base for front end

udittmer — GMT

As to changing the look, it depends on how far you want to go. https://sourceforge.net/p/jforum2/code/HEAD/tree/trunk/src/main/resources/templates/default/styles/style.css has a lot of the colors and fonts and such.

As to moving things around, that would concern the template files. An easy start into that might be the templates for the mobile-optimized pages in https://sourceforge.net/p/jforum2/code/HEAD/tree/trunk/src/main/resources/templates/default/mobile/ as those are a lot simpler than the templates for the desktop look. (Note that the mobile look also has its own CSS definitions.)

Code problem on trunk with template mobile/user_posts_show.htm

udittmer — GMT

Thanks for alerting us to that. It should read "${post.formattedTime}" rather than "${post.time}". That has actually led me to a couple more issues with the handling of relative dates - I just checked in a patch for those.

To keep the mobile view light, the post text isn't included on purpose.